Re: [PATCH V3 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD

[Konrad Dybcio]

On 7/21/26 3:54 PM, Monish Chunara wrote:
> 
> 
> On 7/15/2026 3:44 PM, Konrad Dybcio wrote:
>> On 7/6/26 4:13 PM, Monish Chunara wrote:
>>> From: Monish Chunara <monish.chunara@xxxxxxxxxxxxxxxx>
>>>
>>> Enable SD card for Glymur CRD platform. Configure the vmmc/vqmmc
>>> regulators and gpio-based card detection for the platform.
>>>
>>> Co-developed-by: Sachin Rathore <sachin.rathore@xxxxxxxxxxxxxxxx>
>>> Signed-off-by: Sachin Rathore <sachin.rathore@xxxxxxxxxxxxxxxx>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>>> Signed-off-by: Monish Chunara <monish.chunara@xxxxxxxxxxxxxxxx>
>>> ---
>>>  arch/arm64/boot/dts/qcom/glymur-crd.dts | 24 ++++++++++++++++++++++++
>>>  1 file changed, 24 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts
>>> index c98dfb3941fa..48407e47aaca 100644
>>> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts
>>> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts
>>
>> glymur-crd.dts is the Glymur CRD strictly. glymur-crd.dts*i* is also
>> included for Mahua CRD. Does the SD Card slot exist on both?
>>
>> Konrad
> 
> Yes, Mahua CRD also supports SD cards, so these enablement changes are 
> applicable to Mahua platform as well.
> 
> I'll move these common changes from glymur-crd.dts to glymur-crd.dtsi
> (as is) to better align with the DT structure and allow them to be 
> shared by Mahua CRD. I'll retain the Reviewed-by tag while making this 
> update, if that's acceptable.

Yeah

Konrad