Re: [PATCH v3 16/16] arm_mpam: detect and enable MPAM-Fb PCC support

[Andre Przywara]

Hi Lee,

On 7/15/26 18:08, Lee Trager wrote:
> On 7/10/26 7:45 AM, Andre Przywara wrote:
>
> > diff --git a/drivers/acpi/arm64/mpam.c b/drivers/acpi/arm64/mpam.c
> > index 84963a20c3e7..64bc84bb2029 100644
> > --- a/drivers/acpi/arm64/mpam.c
> > +++ b/drivers/acpi/arm64/mpam.c
> > @@ -256,6 +256,8 @@ static struct platform_device * __init 
> > acpi_mpam_parse_msc(struct acpi_mpam_msc_
> >       } else if (iface == MPAM_IFACE_PCC) {
> >           props[next_prop++] = PROPERTY_ENTRY_U32("pcc-channel",
> >                               tbl_msc->base_address);
> > +        props[next_prop++] = PROPERTY_ENTRY_U32("msc-id",
> > +                            tbl_msc->identifier);
> >       }
>
> props is defined above as:
>
> /* pcc, nrdy, affinity, and a sentinel */
>
> struct property_entry props[4] = { 0 };
>
> With the addition of the new property the array size needs to be 
> increased to 5 and the comment updated

Ouch, that's right. For now we are saved by the fact that the affinity 
value is not used, so there is a free slot now. And there are checks in 
place to avoid writing over the sentinel. But indeed the size needs to 
be increased. Thanks for catching this!

Cheers,
Andre