Re: [PATCHv3 net-next 6/9] net: usb: move exported symbols from cdc_ether to usbnet

[Jakub Kicinski]

On Tue, 14 Jul 2026 13:44:26 +0200 Oliver Neukum wrote:
> --- a/include/linux/usb/usbnet.h
> +++ b/include/linux/usb/usbnet.h
> @@ -16,6 +16,11 @@
>  #include <linux/usb.h>
>  #include <linux/spinlock.h>
>  
> +static const u8 mbm_guid[16] = {
> +	0xa3, 0x17, 0xa8, 0x8b, 0x04, 0x5e, 0x4f, 0x01,
> +	0xa6, 0x07, 0xc0, 0xff, 0xcb, 0x7e, 0x39, 0x2a,
> +};
> +
>  struct cdc_state {
>  	struct usb_cdc_header_desc      *header;
>  	struct usb_cdc_union_desc       *u;
> @@ -304,4 +309,16 @@ extern void usbnet_status_stop(struct usbnet *dev);
>  
>  extern void usbnet_update_max_qlen(struct usbnet *dev);
>  
> +/* We need to override usbnet_*_link_ksettings in bind() */
> +static const struct ethtool_ops cdc_ether_ethtool_ops = {
> +	.get_link		= usbnet_get_link,
> +	.nway_reset		= usbnet_nway_reset,
> +	.get_drvinfo		= usbnet_get_drvinfo,
> +	.get_msglevel		= usbnet_get_msglevel,
> +	.set_msglevel		= usbnet_set_msglevel,
> +	.get_ts_info		= ethtool_op_get_ts_info,
> +	.get_link_ksettings	= usbnet_get_link_ksettings_internal,
> +	.set_link_ksettings	= NULL,
> +};

spews a ton of defined but not used warnings