Re: [PATCH v4 1/3] clk: nuvoton: ma35d1: fix ignored div_u64 return values in PLL freq calculation

[Alexandre Mergnat]

On Tue, 21 Jul 2026 10:13:54 +0800, Joey Lu <a0987203069@xxxxxxxxx> wrote:
> div_u64() does not modify its argument in place; the return value must
> be assigned.  Both ma35d1_calc_smic_pll_freq() and ma35d1_calc_pll_freq()
> called div_u64() and discarded the result, leaving pll_freq holding the
> undivided product and thus returning a frequency orders of magnitude too
> high.
> 
> 
> [...]

Reviewed-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>

-- 
Alexandre Mergnat <amergnat@xxxxxxxxxxxx>