Re: [PATCH v2 2/3] drm/panel: ilitek-ili9805: Use dsi_multi in init

[Michail Tatas]

Hello,

Thanks a lot for the review Neil and Doug, I appreciate the feedback

> > +static void gpm1780a0_init(struct mipi_dsi_multi_context *ctx)
> > +{
> > +       mipi_dsi_dcs_write_seq_multi(ctx, ILI9805_EXTCMD_CMD_SET_ENABLE_REG, ILI9805_SETEXTC_PARAMETER1,
> > +                                                       ILI9805_SETEXTC_PARAMETER2, ILI9805_SETEXTC_PARAMETER3);
> 
> nit: the indentation of the 2nd line of your two-line
> mipi_dsi_dcs_write_seq_multi() seems off. checkpatch.sh --strict
> yells:
> 
> CHECK: Alignment should match open parenthesis
> 
> Strict mode also yells about a few lines that are over 100 characters.
> I'm not quite as picky about that, but it would be nic eto fix too...
> 
> > +       mipi_dsi_msleep(ctx, 100);
> > +       mipi_dsi_dcs_write_seq_multi(ctx, 0xFD, 0x0F, 0x10, 0x44, 0x00);
> > +       mipi_dsi_msleep(ctx, 100);
> > +       mipi_dsi_dcs_write_seq_multi(ctx, 0xf8, 0x18, 0x02, 0x02, 0x18, 0x02, 0x02, 0x30, 0x00,
> > +                                                       0x00, 0x30, 0x00, 0x00, 0x30, 0x00, 0x00);
> 
> Since you're touching these lines anyway, can you also fix these
> functions to consistently use lower case hex instead of (mostly)
> uppercase hex? AKA 0xfd rather than 0xFD.
> 
> 
> Other than above nits, this looks great to me.

I have sent a new version with these changes

Regards,
Michail