Re: [PATCH v3 2/3] drm/panel: ilitek-ili9805: Use dsi_multi in init

[Doug Anderson]

Hi,

On Tue, Jul 21, 2026 at 10:27 AM Michail Tatas <michail.tatas@xxxxxxxxx> wrote:
>
> +static void gpm1780a0_init(struct mipi_dsi_multi_context *ctx)
> +{
> +       mipi_dsi_dcs_write_seq_multi(ctx, ILI9805_EXTCMD_CMD_SET_ENABLE_REG,
> +                                    ILI9805_SETEXTC_PARAMETER1, ILI9805_SETEXTC_PARAMETER2,
> +                                    ILI9805_SETEXTC_PARAMETER3);
> +       mipi_dsi_msleep(ctx, 100);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xfd, 0x0f, 0x10, 0x44, 0x00);
> +       mipi_dsi_msleep(ctx, 100);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xf8, 0x18, 0x02, 0x02, 0x18, 0x02, 0x02, 0x30, 0x00,
> +                                    0x00, 0x30, 0x00, 0x00, 0x30, 0x00, 0x00);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xb8, 0x62);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xf1, 0x00);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xf2, 0x00, 0x58, 0x40);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xf3, 0x60, 0x83, 0x04);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xfc, 0x04, 0x0f, 0x01);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xeb, 0x08, 0x0f);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xe0, 0x00, 0x08, 0x0d, 0x0e, 0x0e, 0x0d, 0x0a, 0x08,
> +                                    0x04, 0x08, 0x0d, 0x0f, 0x0b, 0x1c, 0x14, 0x0a);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xe1, 0x00, 0x08, 0x0d, 0x0e, 0x0e, 0x0d, 0x0a, 0x08,
> +                                    0x04, 0x08, 0x0d, 0x0f, 0x0b, 0x1c, 0x14, 0x0a);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xc1, 0x13, 0x39, 0x19, 0x06);
> +       mipi_dsi_msleep(ctx, 10);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xc7, 0xe5);
> +       mipi_dsi_msleep(ctx, 10);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xb1, 0x00, 0x12, 0x14);
> +       mipi_dsi_msleep(ctx, 10);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xb4, 0x02);
> +       mipi_dsi_msleep(ctx, 10);
> +       mipi_dsi_dcs_write_seq_multi(ctx, 0xbb, 0x14, 0x55);
> +       mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_ADDRESS_MODE, 0x08);
> +       mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_PIXEL_FORMAT, 0x77);

You've already got my Reviewed-by tag, and I'm planning to merge this
patch as-is. ...but my AI happened to notice that the above line could
be:

mipi_dsi_dcs_set_pixel_format_multi(ctx, 0x77)

...so I figured I'd at least mention it. ;-)

My AI also noticed (yet another) pre-existing issue that the "name"
field of "struct ili9805_desc" isn't used in this driver...

-Doug