Re: [PATCH v4 2/2] staging: media: atomisp: Remove dbg_level and dbg_func module parameters

[Andy Shevchenko]

On Tue, Jul 21, 2026 at 10:05:32PM +0530, Prajval Chaudhary wrote:
> Remove the 'dbg_level' and 'dbg_func' module parameters to align the
> driver's debug facility with standard Linux kernel APIs (printk/vprintk).
> 
> The internal logic relying on custom debug parameters has been updated
> so that message logging and function tracing no longer depend on exposed
> userspace module parameters.

...

>  /* cross component debug message flag */
> -int dbg_level;
> -module_param(dbg_level, int, 0644);
> -MODULE_PARM_DESC(dbg_level, "debug message level (default:0)");

And what level is the default now? What the difference with the other levels?

>  /* log function switch */
> -int dbg_func = 1;
> -module_param(dbg_func, int, 0644);
> -MODULE_PARM_DESC(dbg_func,
> -		 "log function switch non/printk (default:printk)");

What are the other options?

...

>  /*! \file */
> -

Stray blank line removal.

> +#include <linux/printk.h>

Locate it in the linux/*.h group below. But I agree that at some point this
custom type_support should be moved down.

>  #include <type_support.h>
>  #include <linux/stdarg.h>
>  #include <linux/bits.h>

-- 
With Best Regards,
Andy Shevchenko