Re: [PATCH v4 1/4] arm64: dts: qcom: Add support for usb nodes on Shikra

[Dmitry Baryshkov]

On Tue, Jul 21, 2026 at 03:23:45PM +0530, Krishna Kurapati wrote:
> Add support for both USB controllers and their respective phys on Shikra.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/shikra.dtsi | 221 +++++++++++++++++++++++++++++++++++
>  1 file changed, 221 insertions(+)
> 
> +
> +		usb_qmpphy: phy@1615000 {

Should be before usb_2_hsphy: phy@1617000.

> +			compatible = "qcom,shikra-qmp-usb3-dp-phy";
> +			reg = <0x0 0x01615000 0x0 0x2000>;
> +
> @@ -493,6 +573,11 @@ qusb2_hstx_trim_1: hstx-trim@25b {
>  				bits = <1 4>;
>  			};
>  
> +			qusb2_hstx_trim_2: hstx-trim@25a {

Before 25b

> +				reg = <0x25a 0x1>;
> +				bits = <4 4>;
> +			};
> +
>  			gpu_speed_bin: gpu-speed-bin@2006 {
>  				reg = <0x2006 0x2>;
>  				bits = <5 8>;
> @@ -640,6 +725,142 @@ &clk_virt SLAVE_QUP_CORE_0 RPM_ALWAYS_TAG>,
>  			};
>  		};
>  
> +		usb_2: usb@4c00000 {
> +			compatible = "qcom,shikra-dwc3", "qcom,snps-dwc3";
> +			reg = <0x0 0x04c00000 0x0 0xfc100>;

Here and in usb_1, missing interconnects.

> +

-- 
With best wishes
Dmitry