Re: [PATCH 2/2] selftests/bpf: Cover stack frame number after scalar plus fp
From: Eduard Zingerman
Date: Tue Jul 21 2026 - 20:14:53 EST
On Tue, 2026-07-21 at 10:29 +0000, bot+bpf-ci@xxxxxxxxxx wrote:
> > diff --git a/tools/testing/selftests/bpf/prog_tests/verifier.c b/tools/testing/selftests/bpf/prog_tests/verifier.c
> > index be97f6887f0e..0483ae340726 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/verifier.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/verifier.c
> > @@ -11,7 +11,6 @@
> > #include "verifier_arena_globals2.skel.h"
> > #include "verifier_array_access.skel.h"
> > #include "verifier_async_cb_context.skel.h"
> > -#include "verifier_basic_stack.skel.h"
> > #include "verifier_bitfield_write.skel.h"
> > #include "verifier_bounds.skel.h"
> > #include "verifier_bounds_deduction.skel.h"
> > @@ -165,7 +164,6 @@ void test_verifier_arena(void) { RUN(verifier_arena); }
> > void test_verifier_arena_large(void) { RUN(verifier_arena_large); }
> > void test_verifier_arena_globals1(void) { RUN(verifier_arena_globals1); }
> > void test_verifier_arena_globals2(void) { RUN(verifier_arena_globals2); }
> > -void test_verifier_basic_stack(void) { RUN(verifier_basic_stack); }
> > void test_verifier_bitfield_write(void) { RUN(verifier_bitfield_write); }
> > void test_verifier_bounds(void) { RUN(verifier_bounds); }
> > void test_verifier_bounds_deduction(void) { RUN(verifier_bounds_deduction); }
>
> The verifier_basic_stack skeleton was already dispatched here through
> RUN(verifier_basic_stack). Adding the new subtest to
> progs/verifier_basic_stack.c on its own would have exercised it under the
> existing harness with no change to prog_tests.
Bot is spot on here.
pw-bot: cr.