Re: [PATCHv2 2/2] dmaengine: fsl_raid: free resources in probe

[Frank Li]

On Tue, Jul 21, 2026 at 02:53:17PM -0700, Rosen Penev wrote:
> On Tue, Jul 21, 2026 at 2:43 PM Frank Li <Frank.li@xxxxxxxxxxx> wrote:
> >
> > On Tue, Jul 21, 2026 at 12:54:22PM -0700, Rosen Penev wrote:
> > > Add free_irq() in the error unwind of fsl_re_chan_probe() and in
> > > fsl_re_remove_chan() so the interrupt is always released.
> > >
> > > Also add tasklet_kill(). Present in _remove but not _probe.
> > >
> > > Also add platform_device_put on failure as of_platform_device_create()

platform_device_put()

> > > increases the reference count and needs platform_device_put on failure.
> > > Requires placing the pointer in the struct for the _remove function.
> > > While at it, use platform_get/set_drvdata as there's no need for using a
> > > device pointer for that.

Needn't "While at ..."

> > >
> > > Fixes: ad80da658bbc ("dmaengine: Driver support for FSL RaidEngine device.")
> > > Assisted-by: opencode:hy3-free
> > > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> > > ---
> > >  drivers/dma/fsl_raid.c | 20 ++++++++++++++------
> > >  drivers/dma/fsl_raid.h |  1 +
> > >  2 files changed, 15 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
> > > index 2d54879cd6e1..cabc79e61e85 100644
> > > --- a/drivers/dma/fsl_raid.c
> > > +++ b/drivers/dma/fsl_raid.c
> > > @@ -661,8 +661,7 @@ static int fsl_re_chan_probe(struct platform_device *ofdev,
> > >       chan_ofdev = of_platform_device_create(np, NULL, dev);
> > >       if (!chan_ofdev) {
> > >               dev_err(dev, "Not able to create ofdev for jr %d\n", q);
> > > -             ret = -EINVAL;
> > > -             goto err_free;
> > > +             return -EINVAL;
> > >       }
> > >
> > >       /* read reg property from dts */
> > > @@ -688,17 +687,19 @@ static int fsl_re_chan_probe(struct platform_device *ofdev,
> > >       chandev = &chan_ofdev->dev;
> > >       tasklet_setup(&chan->irqtask, fsl_re_dequeue);
> > >
> > > +     platform_set_drvdata(chan_ofdev, chan);
> >
> > Previous patch already set, why need set again?
> This is because request_irq uses platform_get_drvdata.
>
> On further review, I think chan should be passed directly.

Yes

Frank
> >
> > Frank
> > >       ret = request_irq(chan->irq, fsl_re_isr, 0, chan->name, chan_ofdev);
> > >       if (ret) {
> > >               dev_err(dev, "Unable to register interrupt for JR %d\n", q);
> > >               ret = -EINVAL;
> > > -             goto err_free;
> > > +             goto err_free_tasklet;
> > >       }
> > >
> > >       re_priv->re_jrs[q] = chan;
> > >       chan->chan.device = dma_dev;
> > >       chan->chan.private = chan;
> > >       chan->dev = chandev;
> > > +     chan->ofdev = chan_ofdev;
> > >       chan->re_dev = re_priv;
> > >
> > >       spin_lock_init(&chan->desc_lock);
> > > @@ -712,7 +713,7 @@ static int fsl_re_chan_probe(struct platform_device *ofdev,
> > >       if (!chan->inb_ring_virt_addr) {
> > >               dev_err(dev, "No dma memory for inb_ring_virt_addr\n");
> > >               ret = -ENOMEM;
> > > -             goto err_free;
> > > +             goto err_free_irq;
> > >       }
> > >
> > >       chan->oub_ring_virt_addr = dma_pool_alloc(chan->re_dev->hw_desc_pool,
> > > @@ -744,8 +745,6 @@ static int fsl_re_chan_probe(struct platform_device *ofdev,
> > >       out_be32(&chan->jrregs->jr_config_1,
> > >                FSL_RE_CFG1_CBSI | FSL_RE_CFG1_CBS0 | status);
> > >
> > > -     platform_set_drvdata(chan_ofdev, chan);
> > > -
> > >       /* Enable RE/CHAN */
> > >       out_be32(&chan->jrregs->jr_command, FSL_RE_ENABLE);
> > >
> > > @@ -754,7 +753,12 @@ static int fsl_re_chan_probe(struct platform_device *ofdev,
> > >  err_free_1:
> > >       dma_pool_free(chan->re_dev->hw_desc_pool, chan->inb_ring_virt_addr,
> > >                     chan->inb_phys_addr);
> > > +err_free_irq:
> > > +     free_irq(chan->irq, chan_ofdev);
> > > +err_free_tasklet:
> > > +     tasklet_kill(&chan->irqtask);
> > >  err_free:
> > > +     of_platform_device_destroy(chan_ofdev);
> > >       return ret;
> > >  }
> > >
> > > @@ -892,6 +896,8 @@ static int fsl_re_probe(struct platform_device *ofdev)
> > >
> > >  static void fsl_re_remove_chan(struct fsl_re_chan *chan)
> > >  {
> > > +     free_irq(chan->irq, chan->ofdev);
> > > +
> > >       tasklet_kill(&chan->irqtask);
> > >
> > >       dma_pool_free(chan->re_dev->hw_desc_pool, chan->inb_ring_virt_addr,
> > > @@ -899,6 +905,8 @@ static void fsl_re_remove_chan(struct fsl_re_chan *chan)
> > >
> > >       dma_pool_free(chan->re_dev->hw_desc_pool, chan->oub_ring_virt_addr,
> > >                     chan->oub_phys_addr);
> > > +
> > > +     of_platform_device_destroy(chan->ofdev);
> > >  }
> > >
> > >  static void fsl_re_remove(struct platform_device *ofdev)
> > > diff --git a/drivers/dma/fsl_raid.h b/drivers/dma/fsl_raid.h
> > > index adbfede330a7..34d362803610 100644
> > > --- a/drivers/dma/fsl_raid.h
> > > +++ b/drivers/dma/fsl_raid.h
> > > @@ -270,6 +270,7 @@ struct fsl_re_chan {
> > >       struct list_head active_q; /* already issued on hw, not completed */
> > >       struct list_head submit_q;
> > >       struct list_head free_q; /* alloc available queue */
> > > +     struct platform_device *ofdev;
> > >       struct device *dev;
> > >       struct fsl_re_drv_private *re_dev;
> > >       struct dma_chan chan;
> > > --
> > > 2.55.0
> > >