Re: [PATCH 1/3] spi: dt-bindings: amlogic: spisg: Document A9-specific properties

[Xianwei Zhao]

Hi Krzysztof,
   Thank you for your advice.

On 2026/7/21 18:18, Krzysztof Kozlowski wrote:
> On Fri, Jul 17, 2026 at 07:49:33AM +0000, Xianwei Zhao wrote:
> > Document the Amlogic A9 SPISG controller and its additional
> > Device Tree properties.
> >
> > Add the "amlogic,a9-spisg" compatible string and define the
> > A9-specific "amlogic,mo-idle-output" and "amlogic,word-gap"
> > properties, which configure the MOSI idle output level and
> > the inter-word gap, respectively.
> >
> > Signed-off-by: Xianwei Zhao<xianwei.zhao@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/spi/amlogic,a4-spisg.yaml  | 36 +++++++++++++++++++---
> >   1 file changed, 32 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/amlogic,a4-spisg.yaml b/Documentation/devicetree/bindings/spi/amlogic,a4-spisg.yaml
> > index 9bfb8089f7ea..7efdc748d566 100644
> > --- a/Documentation/devicetree/bindings/spi/amlogic,a4-spisg.yaml
> > +++ b/Documentation/devicetree/bindings/spi/amlogic,a4-spisg.yaml
> > @@ -11,12 +11,11 @@ maintainers:
> >     - Xianwei Zhao<xianwei.zhao@xxxxxxxxxxx>
> >     - Sunny Luo<sunny.luo@xxxxxxxxxxx>
> >
> > -allOf:
> > -  - $ref: spi-controller.yaml#
> > -
> >   properties:
> >     compatible:
> > -    const: amlogic,a4-spisg
> > +    enum:
> > +      - amlogic,a4-spisg
> > +      - amlogic,a9-spisg
> >
> >     reg:
> >       maxItems: 1
> > @@ -42,6 +41,35 @@ required:
> >     - clocks
> >     - clock-names
> >
> > +allOf:
> > +  - $ref: spi-controller.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - amlogic,a9-spisg
> > +    then:
> > +      properties:
> Properties MUST be defined in top-level. You only restrict them here.
> See writing-schema and example-schema.

Will do.

> Best regards,
> Krzysztof