Re: [PATCH 0/2] staging: media: atomisp: remove unused functions
From: Andy Shevchenko
Date: Wed Jul 22 2026 - 01:09:27 EST
On Wed, Jul 22, 2026 at 7:58 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Jul 22, 2026 at 12:42 AM Nikolay Kulikov <nikolayof23@xxxxxxxxx> wrote:
> >
> > This series removes functions in pci/hmm/ that are declared and defined
> > but never called.
>
> Don't do it per file, squash these changes as it seems not so many of
> them (I assume you checked the entire driver, right?).
Note, if you want to make a useful contribution, try to clean up the
below header
include / hmm / hmm_common.h
It has some ugly macros, instead this code should go to the users and
then be propagated to each level and refactored.
--
With Best Regards,
Andy Shevchenko