Re: [PATCH v3 06/17] media: i2c: os05b10: Add H/V flip support

[Jai Luthra]

Hi Tarang,

Quoting Tarang Raval (2026-07-19 01:38:57)
> Add HFLIP and VFLIP controls, lock them while streaming,
> and update the reported Bayer format based on the flip state.
> 
> Signed-off-by: Tarang Raval <tarang.raval@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/os05b10.c | 56 ++++++++++++++++++++++++++++++++++---
>  1 file changed, 52 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c
> index abf3d2970900..61c51844a91e 100644
> --- a/drivers/media/i2c/os05b10.c
> +++ b/drivers/media/i2c/os05b10.c

[...]

> @@ -556,6 +571,20 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl)
>                 ret = cci_write(os05b10->cci, OS05B10_REG_EXPOSURE,
>                                 ctrl->val, NULL);
>                 break;
> +       case V4L2_CID_HFLIP:
> +       case V4L2_CID_VFLIP:
> +               ret = cci_update_bits(os05b10->cci, OS05B10_REG_FORMAT1,
> +                                     OS05B10_MIRROR | OS05B10_FLIP,
> +                                     (!os05b10->hflip->val ?
> +                                      OS05B10_MIRROR : 0) |
> +                                     (os05b10->vflip->val ?
> +                                      OS05B10_FLIP : 0), NULL);
> +
> +               ret |= cci_write(os05b10->cci, OS05B10_REG_ANALOG_FLIP,
> +                                (os05b10->vflip->val == 1) ?
> +                                OS05B10_FLIP_ENABLE : OS05B10_FLIP_DISABLE,
> +                                NULL);
> +               break;
>         default:
>                 ret = -EINVAL;
>                 break;

Please update the active state format on HFLIP/VFLIP, so the subsequent
G_FMT calls show the correct format.

Many drivers miss this today, I assume because libcamera usually calls
S_FMT on streaming using the output of ENUM_FMT.

Thanks,
    Jai