Re: [PATCH] scripts: headers_install.sh: Normalize __ASSEMBLY__ to __ASSEMBLER__
From: Thomas Huth
Date: Wed Jul 22 2026 - 03:35:52 EST
On 21/07/2026 23.32, Thomas Weißschuh wrote:
On 2026-07-20 12:10:25+0200, Thomas Huth wrote:Ok, I sent a v2 with an updated patch description, I hope that's better:
From: Thomas Huth <thuth@xxxxxxxxxx>
A previous patch to headers_install.sh normalized the usage of
__ASSEMBLER__ to __ASSEMBLY__ in the UAPI headers due to the
assumption that older versions of GCC might not define __ASSEMBLER__
automatically and thus using __ASSEMBLER__ in the UAPI headers might
break compilation with very old versions of GCC. However, as we now
reassured, even GCC 2.95 still defines __ASSEMBLER__ automatically
(and even older versions are hopefully not in use with the current
Linux UAPI headers anymore).
__ASSEMBLER__ is also set automatically by other C compilers like PCC
(see https://github.com/IanHarvey/pcc/blob/cvs2git/2018.09.20/cc/cc/cc.1#L405)
and Tiny-C (see https://repo.or.cz/tinycc.git/commitdiff/a25325e9be13e52a),
so using __ASSEMBLER__ in UAPI header files should really be fine.
I am not that happy about this explanation. The note about old GCC was
dropped in the committed version of the patch.
It should be enough to just explain why __ASSEMBLER__ is better.
https://lore.kernel.org/lkml/20260722072928.24500-1-thuth@xxxxxxxxxx/
If not, please provide a suggestion how it should look like.
Thanks,
Thomas
PS: Nicolas, I kept your Reviewed-by in v2 ... if you disagree with the updated patch description, please complain there!