Re: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

[Andrew Jeffery]

On Wed, 2026-07-22 at 10:21 +0200, Krzysztof Kozlowski wrote:
> On 22/07/2026 09:45, Andrew Jeffery wrote:
> > Hi Jacky,
> > 
> > On Fri, 2026-07-10 at 14:46 +0900, Jacky Huang wrote:
> > > Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera
> > > Rubin NVL compute platform.
> > > 
> > > MAC0 uses phy-mode = "rgmii-id" because the on-board PHY supplies
> > > both RGMII internal delays.  The matching U-Boot device tree does not
> > > enable SoC-side MAC clock delays, leaving the MAC internal delay at
> > > zero so the PHY-provided delay is not doubled by the MAC controller.
> > > 
> > > The corresponding U-Boot change has been submitted to openbmc/u-boot:
> > > Link: https://lore.kernel.org/all/20260629105202.1417679-1-jackyhuang@xxxxxxxxxx/
> > > 
> > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> > > Signed-off-by: Jacky Huang <jackyhuang@xxxxxxxxxx>
> > > ---
> > > v3: reword the &mac0 comment per Andrew Lunn's feedback.
> > > 
> > >  arch/arm/boot/dts/aspeed/Makefile             |   1 +
> > >  .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 901 ++++++++++++++++++
> > >  2 files changed, 902 insertions(+)
> > >  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts
> > 
> > We now have scripts/dtc/dt-check-style, and going forward I'm asking
> > that all new devicetree submissions pass in strict mode.
> 
> Thanks!
> 
> > 
> > Currently:
> > 
> >    $ ../scripts/dtc/dt-check-style --mode strict ../arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts 2>&1 | wc -l
> >    152
> > 
> > Can you please address those?
> 
> Just a note: --strict might not be ready yet. It reports some false
> positives which need addressing (I have plans for this, but busy with
> other things...), so expectation currently is:
> 1. No warnings from standard mode
> 2. Review and investigate warnings from 'strict' mode, but do not fix
> them automatically without thinking

Understood.

Thanks,

Andrew