Re: [PATCH v2 bpf-next 2/5] selftests/bpf: Fix missing allocation null checks in test_progs.c
From: bot+bpf-ci
Date: Wed Jul 22 2026 - 04:52:53 EST
> selftests/bpf: Fix missing allocation null checks in test_progs.c
>
> Add null checks after memory allocations to prevent potential segmentation faults.
>
> Signed-off-by: Feng Yang <yangfeng@xxxxxxxxxx>
This looks like a bug fix, but there is no Fixes: tag. Most of the
corrected allocation sites (dispatcher_threads, data, and
env.worker_current_test in server_main(), and env.worker_pids and
env.worker_socks in main()) were added without null checks when the
parallel worker infrastructure went in. Should this carry:
Fixes: 91b2c0afd00c ("selftests/bpf: Add parallelism to test_progs")
The change also touches two allocation sites from other commits, the
val_buf1/val_buf2 checks in compare_stack_ips() and the
state->subtest_states check in dispatch_thread_send_subtests(), so more
than one Fixes: tag may be warranted, but 91b2c0afd00c covers the bulk
of the change.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/29903681308