Re: [PATCH v2 2/2] scsi: hisi_sas: add spinup_notify callback to handle Active_Wait/Idle_Wait SSP devices
From: John Garry
Date: Wed Jul 22 2026 - 04:55:48 EST
On 21/07/2026 14:33, yangxingui wrote:
In fact, the trigger for this point sometimes fails to take effect.
Yeah, it would be something like that.
But the method to solve this issue is unclear.
Back to the original issue: hisi_sas_spinup_notify_work() calls sl_notify_ssp, but sl_notify_ssp is called already in hisi_sas_phyup_work_common() - so why is it needed to be called again?
If it is because hisi_sas_phyup_work_common() is only for direct- attached disks, and we need to call sl_notify_ssp for expander attached disks?
NOTIFY(SPIN UP) is primarily intended for direct-attached HDD wake-up post-IDENTIFY exchange. Routing it to an Expander may conflict with SAS topology constraints and could disrupt link-layer arbitration, indicating that a conditional disable mechanism for cfg_notify_en in non-direct topologies is advisable.
This problem which you are trying to solve is only for direct-attached disks, right?