Re: [PATCH v2 2/2] arm64: dts: qcom: ipq5210: Enable USB and PCIe on RDP504

[Varadarajan Narayanan]

On Tue, Jul 21, 2026 at 05:36:23PM +0200, Konrad Dybcio wrote:
> On 7/15/26 9:11 AM, Varadarajan Narayanan wrote:
> > RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND
> > share the GPIOs. The board has to be reworked to change from EMMC
> > to NAND variant. Hence add the NAND node but do not enable it.
>
> Does that warrant adding a DT for both variants, both inheriting a
> common .dtsi and making the necessary amends?

Ok.

> > Describe the fixed USB regulators, PCIe reset GPIOs, QPIC SPI NAND flash
>
> Are they controllable? Are they provided by some PMIC?

No. Not provided by PMIC. IPQ5210 doesn't have any software controllable PMIC.

> [...]
>
> > +&pcie0 {
> > +	pinctrl-0 = <&pcie0_default_state>;
> > +	pinctrl-names = "default";
> > +	status = "okay";
>
> Please keep a \n before 'status', uniformly, file-wide

Ok.

> Also 'pcie0' goes before 'pcie0_foo'

Ok.

Thanks
Varada