Re: [PATCH phy-next] phy: lynx-10g: fix lynx_10g_pccr_val_enabled()

[Vinod Koul]

On Fri, 12 Jun 2026 15:57:31 +0300, Vladimir Oltean wrote:
> The intention of the code is to extract the PCCR8_SGMIIa_CFG field out
> of the "pccr" value, not to create a new value with the PCCR8_SGMIIa_CFG
> field set to the "pccr" value.
> 
> Since FIELD_GET() is implemented as ((reg) & (mask)) >> __bf_shf(mask)
> and FIELD_PREP() as (val) << __bf_shf(mask)) & (mask) and since "mask"
> is GENMASK(2, 0), in practice there is no functional difference between
> FIELD_GET() and FIELD_PREP(). But FIELD_GET() is logically the correct
> helper.
> 
> [...]

Applied, thanks!

[1/1] phy: lynx-10g: fix lynx_10g_pccr_val_enabled()
      commit: 1e0c8d50663ae2afd2307d617fd94a53f6a1dc02

Best regards,
-- 
~Vinod