Re: [PATCH v5 32/36] mm/khugepaged: base private node collapse eligiblity on actor/cap bits

From: Gregory Price

Date: Wed Jul 22 2026 - 09:59:40 EST


On Wed, Jul 22, 2026 at 09:24:37PM +0800, Richard Cheng wrote:
> On Mon, Jul 20, 2026 at 03:34:26PM +0800, Gregory Price wrote:
> >
> > page = vm_normal_page(vma, addr, pteval);
> > - if (unlikely(!page) || unlikely(page_is_private_managed(page))) {
> > + if (unlikely(!page) ||
> > + unlikely(!page_allows_collapse(page, cc->is_khugepaged))) {
>
> I think collapse_scan_file() need something like folio_allows_collapse() check as well.
>

I believe you are correct, sashiko up some stuff here too.

Thanks!
~Gregory