Re: [PATCH 10/18] thermal: intel: int340x: Remove redundant dev_err()
From: Rafael J. Wysocki (Intel)
Date: Wed Jul 22 2026 - 11:12:31 EST
On Thu, Jul 9, 2026 at 4:32 AM Pan Chuang <panchuang@xxxxxxxx> wrote:
>
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err() calls that previously printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
> .../intel/int340x_thermal/processor_thermal_device_pci.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
> index c693d934103a..c5131423ec9b 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
> @@ -308,10 +308,8 @@ static int proc_thermal_setup_msi(struct pci_dev *pdev, struct proc_thermal_pci
> ret = devm_request_threaded_irq(&pdev->dev, irq, proc_thermal_irq_handler,
> proc_thermal_irq_thread_handler,
> 0, KBUILD_MODNAME, pci_info);
> - if (ret) {
> - dev_err(&pdev->dev, "Request IRQ %d failed\n", irq);
> + if (ret)
> goto err_free_msi_vectors;
> - }
>
> proc_thermal_msi_map[i] = irq;
> }
> @@ -394,10 +392,8 @@ static int proc_thermal_pci_probe(struct pci_dev *pdev, const struct pci_device_
> ret = devm_request_threaded_irq(&pdev->dev, irq, proc_thermal_irq_handler,
> proc_thermal_irq_thread_handler, irq_flag,
> KBUILD_MODNAME, pci_info);
> - if (ret) {
> - dev_err(&pdev->dev, "Request IRQ %d failed\n", pdev->irq);
> + if (ret)
> goto err_ret_tzone;
> - }
> }
>
> ret = thermal_zone_device_enable(pci_info->tzone);
> --
Applied as 7.3 material, thanks!