Re: [PATCH 11/18] thermal/drivers/intel/bxt_pmic: Remove redundant dev_err()

[Rafael J. Wysocki (Intel)]

On Thu, Jul 9, 2026 at 4:32 AM Pan Chuang <panchuang@xxxxxxxx> wrote:
>
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err() calls that previously printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>  drivers/thermal/intel/intel_bxt_pmic_thermal.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/intel/intel_bxt_pmic_thermal.c b/drivers/thermal/intel/intel_bxt_pmic_thermal.c
> index 6312c6ba081f..aeaefbbd5d8f 100644
> --- a/drivers/thermal/intel/intel_bxt_pmic_thermal.c
> +++ b/drivers/thermal/intel/intel_bxt_pmic_thermal.c
> @@ -245,10 +245,8 @@ static int pmic_thermal_probe(struct platform_device *pdev)
>                                 NULL, pmic_thermal_irq_handler,
>                                 IRQF_ONESHOT, "pmic_thermal", pdev);
>
> -               if (ret) {
> -                       dev_err(dev, "request irq(%d) failed: %d\n", virq, ret);
> +               if (ret)
>                         return ret;
> -               }
>                 pmic_irq_count++;
>         }
>
> --

Applied as 7.3 material, thanks!