Re: [PATCH v7 08/11] KVM: TDX: Get/put PAMT pages when (un)mapping private memory

From: Edgecombe, Rick P

Date: Wed Jul 22 2026 - 13:05:39 EST


On Wed, 2026-07-22 at 07:25 -0700, Sean Christopherson wrote:
> > index 5f6c1ce9673b7..1c706e2d773b0 100644
> > --- a/arch/x86/include/asm/kvm_host.h
> > +++ b/arch/x86/include/asm/kvm_host.h
> > @@ -1922,6 +1922,8 @@ struct kvm_x86_ops {
> >    /* Update external page tables for page table about to be freed. */
> >    void (*free_external_spt)(struct kvm *kvm, struct kvm_mmu_page
> > *sp);
> >  
> > + int (*topup_external_cache)(struct kvm_vcpu *vcpu, int
> > min_nr_spts);
> > +
>
> Unnecessary newline (not your fault, but it stands out here).

Hmm, yea I'll move it with the other external ones. Thanks for the comments.
I'll spin another version.