Re: [PATCH 6.6 0000/1226] 6.6.145-rc2 review

[Frank Scheiner]

On 22.07.26 16:33, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.145 release.
> There are 1226 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Fri, 24 Jul 2026 14:31:21 +0000.
> Anything received after that time might be too late.
> 
> [...]

Our autobuilds for ia64 fail for 6.6.145-rc2 (actually already for
-rc1 but -rc2 was released before I could respond):

```
drivers/cpufreq/ia64-acpi-cpufreq.c:329:27: error: initialization of 'void (*)(struct cpufreq_policy *)' from incompatible pointer type 'int (*)(struct cpufreq_policy *)' [-Wincompatible-pointer-types]
  329 |         .exit           = acpi_cpufreq_cpu_exit,
      |                           ^~~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/ia64-acpi-cpufreq.c:329:27: note: (near initialization for 'acpi_cpufreq_driver.exit')
```

See [1].

[1]: https://github.com/linux-ia64/linux-stable-rc/actions/runs/29932232437/job/88968683064#step:8:3100

This is due to the addition of an upstream change to 
drivers/cpufreq/[...]` ([2]). As this change was introduced after 
v6.6, it didn't change the ia64 specific driver that is still present
for linux-6.6.y.

[2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4b1ddc9dfe997a5f492fa3a36487f8e7a5de30d

In our fork of Linux post v6.6 we carry a replay of b4b1ddc that makes
the corresponding changes also for ia64. This is available on [3] (and
also attached to this message) and fixes the build for me.

[3]: https://github.com/linux-ia64/linux-ia64/commit/a4085ca68e49f49f962ddff46a901ff3468574b8.patch

Can this be included for linux-6.6.y, so it continues to build for
ia64 as is?

Cheers,
Frank
From a4085ca68e49f49f962ddff46a901ff3468574b8 Mon Sep 17 00:00:00 2001
From: Rene Rebe <rene@xxxxxxxxxxxx>
Date: Sun, 1 Dec 2024 19:27:07 +0100
Subject: [PATCH] ia64: Make acpi_cpufreq_cpu_exit return void

Commit b4b1ddc9dfe9 ("cpufreq: Make cpufreq_driver->exit() return
void") changed the type of the cpufreq_driver->exit() interface to
void.

Replay this change for the ia64 cpufreq implementation.

Signed-off-by: Rene Rebe <rene@xxxxxxxxxxxx>
Signed-off-by: Tomas Glozar <tglozar@xxxxxxxxx>
---
 drivers/cpufreq/ia64-acpi-cpufreq.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
index c6bdc455517f85..f692729068f5dd 100644
--- a/drivers/cpufreq/ia64-acpi-cpufreq.c
+++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
@@ -302,7 +302,7 @@ acpi_cpufreq_cpu_init (
 }
 
 
-static int
+static void
 acpi_cpufreq_cpu_exit (
 	struct cpufreq_policy   *policy)
 {
@@ -316,8 +316,6 @@ acpi_cpufreq_cpu_exit (
 		kfree(policy->freq_table);
 		kfree(data);
 	}
-
-	return (0);
 }