Re: [PATCH 1/4] dt-bindings: hwmon: add binding for adi,adt7470

[Rob Herring]

On Thu, Jul 16, 2026 at 06:21:38PM -0300, Luiz Angelo Daros de Luca wrote:
> The Analog Devices ADT7470 is a temperature monitor and PWM fan
> controller. It supports up to 10 external temperature sensors and
> up to 4 PWM fan outputs.
> 
> Add the YAML device tree binding documentation for it. This includes
> support for the thermal framework by defining the "#cooling-cells"
> and "#thermal-sensor-cells" properties.
> 
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>
> ---
>  .../devicetree/bindings/hwmon/adi,adt7470.yaml     | 53 ++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml
> new file mode 100644
> index 000000000000..e0c0fdadd1cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/adi,adt7470.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADT7470 hwmon sensor
> +
> +maintainers:
> +  - Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>
> +
> +description: |

Don't need '|' if no formatting, but if the below is paragraphs, then 
you need '>' and a blank line. But it reads as 1 paragraph to me. In 
that case, your word wrap is off.

> +  The ADT7470 is a temperature monitor and multiple PWM outputs.
> +  It supports monitoring up to 10 external temperature sensors and controlling
> +  up to four fans.
> +
> +properties:
> +  compatible:
> +    const: adi,adt7470
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#cooling-cells":
> +    const: 2
> +    description: |

Don't need '|'.

> +      Cooling device exposing the 4 PWM channels.
> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +    description: |

Don't need '|'.

> +      Number of cells required to uniquely identify the temperature sensors.
> +      Valid index values are 0 to 9, corresponding to temp1 through temp10.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        hwmon@2f {
> +            compatible = "adi,adt7470";
> +            reg = <0x2f>;
> +            #cooling-cells = <2>;
> +            #thermal-sensor-cells = <1>;
> +        };
> +    };
> 
> -- 
> 2.55.0
>