Re: [PATCH v2 2/6] scsi: ufs: Avoid NULL CQE dereference when reporting invalid tags

[Bart Van Assche]

On 7/17/26 8:39 AM, Li Qiang wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 3541da5b6f4d..d1b989abc9e2 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5860,8 +5860,8 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
>   	struct ufshcd_lrb *lrbp = scsi_cmd_priv(cmd);
>   	enum utp_ocs ocs;
>   
> -	if (WARN_ONCE(!cmd, "cqe->command_desc_base_addr = %#llx\n",
> -		      le64_to_cpu(cqe->command_desc_base_addr)))
> +	if (WARN_ONCE(!cmd, "invalid completion tag %d, cqe->command_desc_base_addr = %#llx\n",
> +		      task_tag, cqe ? le64_to_cpu(cqe->command_desc_base_addr) : 0ULL))
>   		return;

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>