Re: [PATCH net v3] rds: tcp: hold the RCU lock across ipv6_chk_addr() in rds_tcp_laddr_check()

From: Xiang Mei

Date: Wed Jul 22 2026 - 16:08:31 EST


On Wed, Jul 22, 2026 at 11:27 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 14 Jul 2026 14:22:39 -0700 Xiang Mei wrote:
> > Changes since v1:
> > Use rcu_read_locks instead of dev_hold/put
> > Rebased on [PATCH net v2] rds: Fix inet6_addr_lst NULL dereference when IPv6 is disabled
> >
> > Changes since v2:
> > Add change log
>
> Why did you(r LLM) leave this portion of the change log in here and the
> rest in the correct place below?
>
I added that based on Allison Henderson's suggestion of v2. I don't
know how the change log works, so I may misunderstand Allison's
suggestion.
I'll do some research to fix that in v4.
(https://lore.kernel.org/all/f69ec0975481ad04dc7403834bbb6b93d1092ecb.camel%40kernel.org/)

> > Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
> > Reported-by: Weiming Shi <bestswngs@xxxxxxxxx>
> > Assisted-by: Claude:claude-opus-4-8
> > Signed-off-by: Xiang Mei <xmei5@xxxxxxx>
> > Reviewed-by: Allison Henderson <achender@xxxxxxxxxx>
> > ---
> > v2: Use rcu_read_locks and rebase on rds: Fix inet6_addr_lst NULL
> > dereference when IPv6 is disabled
> > v3: Add change log to commit message as Allison suggested
>
> The patch does not apply, if it's still relevant please rebase and
> repost.
> --
> pw-bot: cr

I'll check the rebase issue, thanks.

Xiang