Re: [PATCH 0/3] tools/mm/page_owner_sort: fix --sort, add module filter, improve usage

[Andrew Morton]

On Wed, 22 Jul 2026 10:37:23 +0800 Ye Liu <ye.liu@xxxxxxxxx> wrote:

> This series improves the page_owner_sort tool with a bug fix, a new
> module-name feature, and better usage text.
> 
> Patch 1 fixes a long-standing bug where --sort was silently ignored
> when used without a short option (-a, -m, -p, etc.).  The COMP_NO_FLAG
> case fell through to COMP_NUM and overwrote the sort conditions
> configured by parse_sort_args().
> 
> Patch 2 adds kernel module name support for sort, cull, and filter
> operations.  Page owner stack traces already contain module names in
> the [module] format produced by %pS, but page_owner_sort had no way
> to use them.  Records without module frames are assigned "vmlinux".
> 
>   # Aggregate page usage per module
>   ./page_owner_sort input.txt output.txt --cull=mod
> 
>   # Filter to records from xfs module only
>   ./page_owner_sort input.txt output.txt --module xfs
> 
>   # Sort by module name, then by pid descending
>   ./page_owner_sort input.txt output.txt --sort=mod,-pid
> 
> Patch 3 lists all available sort keys with abbreviations and examples
> directly in the --sort help section so users no longer need to read
> the source to discover valid keys.

Thanks, these sound like nice changes.

AI review mentioned a couple of things, at least one of which appears legit:
	https://sashiko.dev/#/patchset/20260722023726.600200-1-ye.liu@xxxxxxxxx