Re: [PATCH] selftests: futex: Restore support checks for futex2 and priv_hash

[Wake Liu]

Hi Carlos, André,

Ah, sorry about that. I didn't realize that I had already submitted
the exact same patch and that Thomas had already merged/refactored it.
Please ignore my previous email.

Best regards,
Wake

On Thu, Jul 23, 2026 at 12:52 AM Carlos Llamas <cmllamas@xxxxxxxxxx> wrote:
>
> On Wed, Jul 22, 2026 at 12:20:37PM -0300, André Almeida wrote:
> > Hi Wake,
> >
> > Em 22/07/2026 04:08, Wake Liu escreveu:
> > > Older kernels may not support FUTEX2 syscalls or PR_FUTEX_HASH.
> > > Removing these checks causes false failures when running the tests on
> > > such kernels. Restore the checks so the tests can be gracefully
> > > skipped when the features are not supported.
> > >
> > > Signed-off-by: Wake Liu <wakel@xxxxxxxxxx>
> > > ---
> > >   tools/testing/selftests/futex/functional/futex_numa_mpol.c | 2 ++
> > >   tools/testing/selftests/futex/functional/futex_priv_hash.c | 2 ++
> > >   2 files changed, 4 insertions(+)
> > >
> > > diff --git a/tools/testing/selftests/futex/functional/futex_numa_mpol.c b/tools/testing/selftests/futex/functional/futex_numa_mpol.c
> > > index 78c0f7a59e17..d215acf88120 100644
> > > --- a/tools/testing/selftests/futex/functional/futex_numa_mpol.c
> > > +++ b/tools/testing/selftests/futex/functional/futex_numa_mpol.c
> > > @@ -103,6 +103,8 @@ static void __test_futex(void *futex_ptr, int err_value, unsigned int futex_flag
> > >                     break;
> > >             }
> > >             if (ret < 0) {
> > > +                   if (errno == ENOSYS || (errno == EINVAL && (futex_flags & FUTEX2_NUMA)))
> > > +                           ksft_exit_skip("futex2 or FUTEX2_NUMA not supported by kernel\n");
> >
> > Why aren't you using SKIP() instead of ksft_exit_skip() like how you have
> > done at
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=locking/futex&id=50c121e5a57abe446e46825fb9c69ac419765d5c
>
> It's actually the same patch. See:
> https://lore.kernel.org/all/20260624070223.1533167-1-wakel@xxxxxxxxxx/
> Thomas, just refactored it to use the harness API.
>
> I'm not sure why Wake sent the same fix twice but it was likely by
> mistake. That's all, nothing to see here.
>
> --
> Carlos Llamas



-- 
Best Regards,
Wake Liu