Re: [PATCH 1/3] perf: Remove redundant dev_err()/dev_err_probe()

[Shuai Xue]

On 7/17/26 6:31 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>   drivers/perf/alibaba_uncore_drw_pmu.c | 5 +----
>   drivers/perf/fsl_imx8_ddr_perf.c      | 4 +---
>   drivers/perf/fsl_imx9_ddr_perf.c      | 4 +---
>   drivers/perf/fujitsu_uncore_pmu.c     | 2 +-
>   drivers/perf/qcom_l2_pmu.c            | 5 +----
>   drivers/perf/qcom_l3_pmu.c            | 5 +----
>   drivers/perf/starfive_starlink_pmu.c  | 2 +-
>   drivers/perf/xgene_pmu.c              | 4 +---
>   8 files changed, 8 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
> index 74786a5dd6a2..fc934bccf4a6 100644
> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
> @@ -449,11 +449,8 @@ static struct ali_drw_pmu_irq *__ali_drw_pmu_init_irq(struct platform_device
>   	 */
>   	ret = devm_request_irq(&pdev->dev, irq_num, ali_drw_pmu_isr,
>   			       IRQF_SHARED, dev_name(&pdev->dev), irq);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev,
> -			"Fail to request IRQ:%d ret:%d\n", irq_num, ret);
> +	if (ret < 0)
>   		goto out_free;
> -	}
>   
>   	ret = irq_set_affinity_hint(irq_num, cpumask_of(irq->cpu));
>   	if (ret)
For Alibaba PMU part,

Reviewed-by: Shuai Xue <xueshuai@xxxxxxxxxxxxxxxxx>

Thanks,
Shuai