Re: [PATCH] fbdev: replace dead select with dependency
From: Arnd Bergmann
Date: Thu Jul 23 2026 - 02:44:35 EST
On Thu, Jul 23, 2026, at 00:00, Julian Braha wrote:
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 085d3a202148..1ed4506c0cb2 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1717,8 +1717,8 @@ config FB_MB862XX_PCI_GDC
> config FB_MB862XX_LIME
> bool "Lime GDC"
> depends on OF && PPC
> - select FB_FOREIGN_ENDIAN
> - select FB_LITTLE_ENDIAN
> + depends on FB_FOREIGN_ENDIAN
> + depends on FB_LITTLE_ENDIAN
> help
> Framebuffer support for Fujitsu Lime GDC on host CPU bus.
I would make this one
select FB_FOREIGN_ENDIAN
depends on FB_LITTLE_ENDIAN || FB_BOTH_ENDIAN
to avoid breanking defconfig files. The default choice is
FB_BOTH_ENDIAN, and that should work fine here.
Arnd