Re: [PATCH v2 2/2] ARM: dts: aspeed-g6: add pcie-kcs4

[Grégoire Layet]

Hi Andrew,

> >  arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > index 56bb3b0444f7..a93fa4cf5d8f 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > @@ -617,6 +617,13 @@ kcs4: kcs@114 {
> >                                       status = "disabled";
> >                               };
> >
> > +                             pcie_kcs4: kcs@914 {
>
> Nodes need to be ordered by ascending address:

The existing kcs4 node is already not in ascending order of address.

'kcs4: kcs@114' is before 'lpc_ctrl: lpc-ctrl@80'

pcie_kcs4 has been placed here to have ascending addresses locally on
the kcs nodes and still
having all the kcs nodes next to each other. This matches the kcs4
node ordering.

If ascending address is still preferred, I'll change pcie_kcs4 order of course.

Regards,
Grégoire