Re: [PATCH v2 1/2] dt-bindings: iio: magnetometer: add QST QMC6308

[Krzysztof Kozlowski]

On Tue, Jul 21, 2026 at 03:48:42PM +0200, Jorijn van der Graaf wrote:
> Add device tree bindings for the QST QMC6308, a 3-axis anisotropic
> magnetoresistive (AMR) magnetometer. It is an I2C device with a single
> supply and no interrupt pin, at I2C address 0x2c.
> 
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Jorijn van der Graaf <jorijnvdgraaf@xxxxxxxxxxxxx>
> ---
> v2:
> - Spell out AMR (anisotropic magnetoresistive) (Jonathan).
> - Drop the package mentions from the description and commit message
>   (Jonathan).
> - compatible: enum -> const (Jonathan).
> - Use the current GPL-2.0-only form in the SPDX identifier.
> - Kept as a separate file rather than folded into
>   qstcorp,qmc5883l.yaml - the two schemas share only
>   compatible/reg/vdd-supply; see the cover letter.
> 
> v1: https://lore.kernel.org/20260714202842.340293-2-jorijnvdgraaf@xxxxxxxxxxxxx
> 
>  .../iio/magnetometer/qstcorp,qmc6308.yaml     | 47 +++++++++++++++++++
>  MAINTAINERS                                   |  6 +++
>  2 files changed, 53 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml b/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml
> new file mode 100644
> index 000000000000..6201a44cfe38
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/qstcorp,qmc6308.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: QST QMC6308 3-Axis Magnetic Sensor
> +
> +maintainers:
> +  - Jorijn van der Graaf <jorijnvdgraaf@xxxxxxxxxxxxx>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  QST QMC6308 3-axis anisotropic magnetoresistive (AMR) magnetic sensor
> +  on I2C bus, with a single supply and no interrupt pin.
> +  https://qstcorp.com/upload/pdf/202202/13-52-15%20QMC6308%20Datasheet%20Rev.%20F(1).pdf
> +
> +properties:
> +  compatible:
> +    const: qstcorp,qmc6308
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  mount-matrix: true
> +
> +additionalProperties: false

This goes after "required:" block.

No need to resend just for these.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof