Re: [PATCH] x86/purgatory: Return bool from verify_sha256_digest()

[Ingo Molnar]

* Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:

> -	if (memcmp(digest, purgatory_sha256_digest, sizeof(digest)))
> -		return 1;
> -
> -	return 0;
> +	return memcmp(digest, purgatory_sha256_digest, sizeof(digest)) == 0;

Could you please write this as !memcmp()? The == 0 variant is
quite a bad pattern for such a long line, as it's far easier
to miss during review than a ! unary operator...

Just like here:

> +	if (!verify_sha256_digest()) {

Thanks,

	Ingo