Re: [PATCH v2 01/10] dt-bindings: hwmon: Describe Qualcomm BCL hardware
From: Krzysztof Kozlowski
Date: Thu Jul 23 2026 - 04:12:00 EST
On Wed, Jul 22, 2026 at 12:00:06AM +0530, Manaf Meethalavalappu Pallikunhi wrote:
> +properties:
> + compatible:
> + enum:
> + - qcom,pm7250b-bcl
> + - qcom,pm8350c-bcl
> + - qcom,pm8550-bcl
> + - qcom,pmh0101-bcl
> + - qcom,pmih0108-bcl
> + - qcom,smb2360-bcl
> + - qcom,smb2370-bcl
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 2
> +
> + interrupt-names:
> + items:
> + - const: max-min
> + - const: critical
> +
Binding looks in general ok, but feels incomplete. If this is battery
limiting hardware, does it actually need any battery data through
monitored-battery property?
Best regards,
Krzysztof