Re: [PATCH 1/2] crypto: pcrypt - Remove pcrypt

From: David Laight

Date: Thu Jul 23 2026 - 04:13:28 EST


On Thu, 23 Jul 2026 08:30:47 +0900
Simon Richter <Simon.Richter@xxxxxxxxxx> wrote:

> Hi,
>
> On 7/23/26 4:40 AM, Eric Biggers wrote:
>
> > So while maybe pcrypt does still help a bit on this platform for now,
> > the approach does seem quite dated and largely a workaround for
> > inefficiencies elsewhere in the stack (including systems where the
> > optimized crypto code is accidentally not enabled).
>
> There is one additional aspect: offloading frees the CPU to do something
> else -- and that is where even offload engines that are slower than the
> CPU can still be beneficial in the big picture.

Provided what is being offload actually takes long enough to allow for
setting up the iommu, the two context switches and the interrupt as well as
the obvious setup costs.

David

>
> Simon
>