Re: [PATCH v2 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc
From: Abel Vesa
Date: Thu Jul 23 2026 - 04:31:48 EST
On 26-07-22 16:10:07, Dmitry Baryshkov wrote:
> On Wed, Jul 22, 2026 at 02:01:27PM +0300, Abel Vesa wrote:
> > On 26-07-22 01:30:27, Dmitry Baryshkov wrote:
> > > On Tue, Jul 21, 2026 at 11:25:48AM +0300, Abel Vesa wrote:
> > > > Describe the CDSP remoteproc along with the related SMP2P.
> > >
> > > Why is there no glink-edge / FastRPC? They might be not yet supported,
> > > but please mention it in the commit message. GLINK should probably work.
> >
> > I'll include the glink-edge in this patch.
> >
> > The FastPRC was sent separately, later, because it wasn't tested in time
> > to be sent together. Mentioned here:
> > https://lore.kernel.org/all/20260721-dts-qcom-eliza-add-fastrpc-v1-1-cbea68d8e01b@xxxxxxxxxxxxxxxx/
> >
> > I don't think commit message should talk about future work though.
>
>
> I would not 100% agree here. It simplifies work of the reviewers. If I
> see a DSP w/o glink or FastRPC, I need to think why it is not present.
> Is it something which doesn't have GLINK support? Or are there any other
> issues? While stating that abc will be done later saves us from those
> questions.
>
> For me it's similar to the USB support. It's not infrequent to get only
> host or only peripheral supported in the first patch. But the commit
> message needs to specify if it's a hardware limitation, a software
> limiation or something which wasn't done yet.
OK then, will mention in the commit message that FastRPC is submitted
separately.