Re: [PATCH net-next v2 7/7] selftests: net: getsockopt_iter: cover rawv6, ieee802154, phonet and tls

[Sabrina Dubroca]

2026-07-20, 09:17:48 -0700, Breno Leitao wrote:
> Add fixtures for the newly converted getsockopt leaves:
> 
>   - rawv6:      IPV6_HDRINCL / IPV6_CHECKSUM int paths + a SOL_RAW
>                 unknown-optname case that reaches do_rawv6_getsockopt().
>   - ieee802154: WPAN_WANTACK dgram int path + non-SOL_IEEE802154 level
>                 rejection.
>   - phonet:     PNPIPE_ENCAP pep int path + non-SOL_PNPIPE level
>                 rejection.
>   - tls:        TLS_TX_ZEROCOPY_RO, the TLS_TX crypto_info round-trip at
>                 the base and full cipher sizes, the NULL-optval and short
>                 buffer EINVAL paths, and an unknown optname. It skips when
>                 the kernel lacks TLS or AES-GCM.
> 
> Each fixture pins the returned-length / errno semantics across exact,
> oversized and short buffers, an unknown optname and a bogus level. The
> semantics are unchanged by the sockopt_t conversion, so the tests pass
> both before and after the leaf conversions.
> 
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> Acked-by: Rémi Denis-Courmont <remi@xxxxxxxxxx>
> ---

> +/* ---------- tls ---------- */

The TLS tests themselves look good.
Reviewed-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>

I guess there's a question here (for components that already have
their own tests, so I think just tls for this patch) about whether
getsockopt tests belong with the other component tests (net/tls.c) or
in this getsockopt_iter group.

-- 
Sabrina