Re: [PATCH v2 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support

[Konrad Dybcio]

On 7/23/26 3:46 AM, Aneesh Pradhan wrote:
> From: "Catherine Frederick (coolguy)" <serenity@xxxxxxxxxxxxx>
> 
> Add MSM8917 and MSM8920 board files for the Motorola Moto E4 (perry)
> sharing a common dtsi, shaped against in-tree msm8917-xiaomi-wingtech /
> msm8937-xiaomi-land so every referenced label exists on mainline.

Do we know whether both MSM8917 and MSM8920 variants actually exist
in the wild? It's common practice for vendors to include an oversized
set of msm-ids in their downstream forks, either because of negligence
or because decisions change during product development.

> 
> Initial subset: regulators, eMMC/SD, USB OTG (gpio extcon), gpio-keys,
> Synaptics RMI4 touchscreen, BMA253 via i2c-gpio, WCNSS Wi-Fi
> (qcom,wcn3660b), and PMI8950 WLED.
> 
> Deferred (missing mainline SoC/PMIC nodes or drivers): DSI panel/MDSS,
> IPA, QDSP6/WCD audio, PMI8950 FG/smbcharger, modem/ADSP/Venus remoteprocs.
> 
> Validated on XT1765 under postmarketOS with a fuller fork DT carry; this
> is the trimmed upstream-first subset.

You should definitely validate the changes you send on their own, atop
linux-next/master

[...]

> +		/* Early console deferred with MDSS; panel driver not upstream yet. */
> +		stdout-path = "framebuffer0";
> +
> +		framebuffer0: framebuffer@90001000 {
> +			compatible = "simple-framebuffer";
> +			reg = <0x0 0x90001000 0x0 (720 * 1280 * 3)>;

Please use memory-region instead of reg here

> +			width = <720>;
> +			height = <1280>;
> +			stride = <(720 * 3)>;
> +			format = "r8g8b8";
> +
> +			clocks = <&gcc GCC_MDSS_AHB_CLK>,
> +				 <&gcc GCC_MDSS_AXI_CLK>,
> +				 <&gcc GCC_MDSS_VSYNC_CLK>,
> +				 <&gcc GCC_MDSS_MDP_CLK>,
> +				 <&gcc GCC_MDSS_BYTE0_CLK>,
> +				 <&gcc GCC_MDSS_PCLK0_CLK>,
> +				 <&gcc GCC_MDSS_ESC0_CLK>;
> +			power-domains = <&gcc MDSS_GDSC>;
> +			status = "disabled";

Is this disable an oversight?


> +&blsp1_i2c3 {
> +	status = "okay";
> +
> +	touchscreen@20 {
> +		compatible = "syna,rmi4-i2c";
> +		reg = <0x20>;
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <65 IRQ_TYPE_EDGE_FALLING>;

interrupts-extended = <&tlmm 65 IRQ..

[...]


> +&usb {
> +	extcon = <&usb_id>, <&usb_id>;
> +	dr_mode = "otg";
> +	status = "okay";

Please uniformly keep a \n before 'status'

[...]

> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2025 Val Packett

I'm confused as to why Val Packett's copyright is there. Is that the
same person as the aforementioned Catherine Frederick?

Konrad