Re: [PATCH v5] x86/sgx: Report RCU-Tasks quiescent state in EPC sanitization loop

From: Jarkko Sakkinen

Date: Thu Jul 23 2026 - 09:13:37 EST


On Thu, Jul 23, 2026 at 09:57:33AM +0000, Miao, Jun wrote:
> >You should probably also say why cond_resched() does not trigger
> >rescheduling. E.g., put that and delete the first sentence as it tells nothing
> >and is confusing.
>
> Hi BR, Jarkko,
>
> How about I place the explanation as a comment above the code at the v6 version ?
> See the description below.
>
> Warm regards
> Jun Miao

Yeah, that is exactly kind of reminder that would make sense there.

>
> >> --- a/arch/x86/kernel/cpu/sgx/main.c
> >> +++ b/arch/x86/kernel/cpu/sgx/main.c
> >> - cond_resched();
> + /*
> + * cond_resched() only schedules when TIF_NEED_RESCHED is set.
> + * During this boot-time loop that condition may not happen for a
> + * long time, so report an RCU-Tasks quiescent state explicitly.
> + */
>
> >> + cond_resched_tasks_rcu_qs();
> >> }
> >>
> >> list_splice(&dirty, dirty_page_list);
> >> --
> >> 2.32.0
> >>
> >
> >

BR, Jarkko