Re: [PATCH wireless-next] wifi: mwifiex: Use flexible array for RX reorder table

[Francesco Dolcini]

Hello Johannes,

On Tue, May 19, 2026 at 08:47:00AM +0200, Johannes Berg wrote:
> On Mon, 2026-05-18 at 14:18 -0700, Rosen Penev wrote:
> > Embed the RX reorder pointer array in struct mwifiex_rx_reorder_tbl
> > instead of allocating it separately.
> 
> Others might disagree, but personally, I think you should stop doing
> this. Sure, it *might* (I've been bitten too much by __counted_by) be a
> border-line improvement, but it's not _really_ all that useful,
> especially on these older drivers.
> 
> Did you even test it at all?
> 
...
> If you _really_ want to help, please help review changes rather than
> producing more noise. Maybe even take over maintenance of some specific
> driver that you can test.

I also do not see any specific reason to take this, as of now I have not
enough brain cycles available to properly review this, and if this is
not even tested we should just reject it.

Francesco