Re: [PATCH v4 1/3] media: iris: cache work mode after computing it in iris_set_stage

[Vikash Garodia]

On 7/23/2026 3:51 PM, Sachin Kumar Garg wrote:
> iris_set_stage() computes work_mode and sends it to firmware but
> never updates inst->fw_caps[STAGE].value, leaving the cached STAGE
> value stale. iris_vpu_enc_bin_size() and
> iris_vpu3x_vpu4x_calculate_frequency() read this cached value, so a
> stale default causes them to miscalculate buffer size and clock
> frequency for sessions actually running in a different stage than
> the cached one.
>
> Update inst->fw_caps[cap_id].value with the computed work_mode
> before sending it to firmware, keeping the cache consistent with
> what is actually configured.
>
> Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon")
> Signed-off-by: Sachin Kumar Garg<sachin.garg@xxxxxxxxxxxxxxxx>
> ---
>   drivers/media/platform/qcom/iris/iris_ctrls.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>