[PATCH 19/36] dmaengine: qcom_hidma: remove conditional return with no effect
From: Sang-Heon Jeon
Date: Thu Jul 23 2026 - 15:01:05 EST
Both branches of the check return the same value, so the check has
no effect. Remove it and return the value directly.
This is the result of running the Coccinelle script from
scripts/coccinelle/misc/cond_return_no_effect.cocci.
Signed-off-by: Sang-Heon Jeon <ekffu200098@xxxxxxxxx>
---
drivers/dma/qcom/hidma_ll.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/dma/qcom/hidma_ll.c b/drivers/dma/qcom/hidma_ll.c
index 53244e0e34a3..f081aa787f0c 100644
--- a/drivers/dma/qcom/hidma_ll.c
+++ b/drivers/dma/qcom/hidma_ll.c
@@ -677,11 +677,7 @@ int hidma_ll_setup(struct hidma_lldev *lldev)
/* configure interrupts */
hidma_ll_setup_irq(lldev, lldev->msi_support);
- rc = hidma_ll_enable(lldev);
- if (rc)
- return rc;
-
- return rc;
+ return hidma_ll_enable(lldev);
}
void hidma_ll_setup_irq(struct hidma_lldev *lldev, bool msi)
--
2.43.0