Re: [PATCH] wifi: cfg80211: publish PMSR request before starting the driver

From: Zhao Li

Date: Thu Jul 23 2026 - 16:23:11 EST


On Thu, 23 Jul 2026 at 10:18:33 +0200, Johannes Berg wrote:
> However, I don't think it makes sense to actually *document* that it's
> now possible - it's only possible from the kernel's locking POV, from
> userspace's POV it's still highly confusing at best, and it makes no
> sense semantically either.

Agreed. I'll drop the kernel-doc changes. Documenting it implies it's a
supported semantic when it's really just a locking side effect.

> That comment then should call out how it's really about preventing races
> with drivers from doing UAF (we could technically be preempted here too),
> rather than making that sound like a reasonable order - just saying "Under
> races and/or broken drivers immediate completion might free it ..." or
> something along those lines would be better I think.

Exactly. I'll reword the comment to frame it as defensive against races
and broken drivers, not as an intentional ordering.

Will send a v2.

Thanks,
Zhao