Re: [PATCH] iio: chemical: cleanup codestyle warning
From: Joshua Crofts
Date: Thu Jul 23 2026 - 17:54:29 EST
On Thu, 23 Jul 2026 23:51:39 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> On Fri, 24 Jul 2026 00:10:38 +0800
> Adi Nata <adinata.softwareengineer@xxxxxxxxx> wrote:
>
> > Reported by checkpatch:
> > FILE: drivers/iio/chemical/ccs811.c
> >
> > WARNING: Prefer __packed over __attribute__((__packed__))
> > +} __attribute__((__packed__));
>
> Perhaps a nit, but I'd change the commit title to "prefer __packed"
> and the commit message to something like:
>
> "Change instance of __attribute__((__packed__)) to __packed per
> checkpatch.pl warning.
>
> Other than that:
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
Additionally, you're missing the driver name in the subject/commit
message, it should be something like "iio: chemical: ccs811: prefer __packed"
--
Kind regards,
Joshua Crofts