Re: [PATCH 4/4] iio: dac: ad5686: update device list and file header comments

[Jonathan Cameron]

On Mon, 20 Jul 2026 12:27:34 +0100
Rodrigo Alencar <455.rodrigo.alencar@xxxxxxxxx> wrote:

> On 19/07/26 22:30, Jonathan Cameron wrote:
> > On Sun, 19 Jul 2026 10:52:00 +0100
> > Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@xxxxxxxxxx> wrote:
> >   
> > > From: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
> > > 
> > > Update device list entries in Kconfig and remove device description from
> > > file headers. One can rely on the ID table(s) to check for supported
> > > devices. Adjust comment header accordingly and update Copyright notice in
> > > comment file headers with the current year.
> > > 
> > > Signed-off-by: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
> > > ---  
> > 
> > Main comments here are about the patch break up.  I think it needs
> > just enough modification for a v2 to be needed.
> >   
> > >  drivers/iio/dac/Kconfig      | 31 ++++++++++++++++++++++++-------
> > >  drivers/iio/dac/ad5686-spi.c |  7 ++-----
> > >  drivers/iio/dac/ad5686.c     |  4 ++--
> > >  drivers/iio/dac/ad5696-i2c.c |  6 ++----
> > >  4 files changed, 30 insertions(+), 18 deletions(-)
> > > 
> > > diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> > > index d6d560c09e25..ba2065241af3 100644
> > > --- a/drivers/iio/dac/Kconfig
> > > +++ b/drivers/iio/dac/Kconfig
> > > @@ -251,9 +251,18 @@ config AD5686_SPI
> > >  	depends on SPI
> > >  	select AD5686
> > >  	help
> > > -	  Say yes here to build support for Analog Devices AD5672R, AD5674R,
> > > -	  AD5676, AD5676R, AD5679R, AD5684, AD5684R, AD5684R, AD5685R, AD5686,
> > > -	  AD5686R Voltage Output Digital to Analog Converter.  
> > 
> > Given this is adding entrees that were in the previous patch, I'd have
> > preferred to see the more complex dance of a precursor patch before that
> > which did the reformat (and dropped the stuff form the c files)
> > 
> > That would then be followed the new stuff being added as part of the previous
> > patch.
> > 
> > Whilst the ends result is the same I think it is worth doing a v2 just
> > to clean that break down of patches up.
> >   
> > > +	  Say yes here to build support for Analog Devices Voltage Output
> > > +	  Digital to Analog Converters:
> > > +	  - Single-channel:
> > > +	    AD5310R, AD5681R, AD5682R, AD5683R, AD5683R  
> > 
> > Eagle eyed Sashiko spotted last entry is a duplicate.  
> 
> Yeah, one of the entries should have been just AD5683...
> 
> Also, that this AD5337R was missing, which I didnt add because I could not
> find documentation for this one. Maybe a device that does not exists or it
> was deprecated.

We've had a few IDs sneak in either through typos or because a part
existed on a datasheet but wasn't released in the end.

Good idea to just not mention it here though we might get someone
helpfully 'fixing' the fact it was missed in future :(

> > > diff --git a/drivers/iio/dac/ad5686-spi.c b/drivers/iio/dac/ad5686-spi.c
> > > index 003541edb742..b4531b49cb22 100644
> > > --- a/drivers/iio/dac/ad5686-spi.c
> > > +++ b/drivers/iio/dac/ad5686-spi.c
> > > @@ -1,11 +1,8 @@
> > >  // SPDX-License-Identifier: GPL-2.0
> > >  /*
> > > - * AD5672R, AD5674R, AD5676, AD5676R, AD5679R,
> > > - * AD5681R, AD5682R, AD5683, AD5683R, AD5684,
> > > - * AD5684R, AD5685R, AD5686, AD5686R
> > > - * Digital to analog converters driver
> > > + * SPI driver for AD5686 and similar Digital to Analog Converters
> > >   *
> > > - * Copyright 2018 Analog Devices Inc.
> > > + * Copyright 2018-2026 Analog Devices Inc.  
> > 
> > That definitely belongs in the patch that made a real change, not one
> > that is just messing with comments.  
> 
> Will drop this one. As I was touching the file headers I assumed it was fine
> to put this here, given that I ended up adding a lot of changes to these files
> lately.

The change to update the copyright is fine.  Just do it in patch 3
instead as that is where you are making substantial changes and a copyright
update is appropriate.  If you were updating that for other recent changes
and didn't have any in this series, then separate patch where you can say that
it is about other recent changes.

Jonathan

>