RE: [PATCH 0/4] usb: enable sysfs module symlink for more built-in drivers

[Bird, Tim]

> -----Original Message-----
> From: Mahadasyam, Shashank (SGC) <Shashank.Mahadasyam@xxxxxxxx>
> Subject: [PATCH 0/4] usb: enable sysfs module symlink for more built-in drivers
> 
> This is in continuation to [1].
> 
> struct device_driver's mod_name is not set by a number of bus' driver registration
> functions. Without that, built-in drivers don't have the module symlink in sysfs.
> We want this to go from unbound driver name -> module name -> kernel config name.
> This is useful on embedded platforms to minimize kernel config, reduce kernel size,
> and reduce boot time.
> 
> This patchset adds mod_name to usb-related drivers.
> 
> [1] https://lore.kernel.org/all/20260518-acpi_mod_name-v5-0-705ccc430885@xxxxxxxx/
> 
> Signed-off-by: Shashank Balaji <shashank.mahadasyam@xxxxxxxx>
> ---
> Shashank Balaji (4):
>       usb: core: pass THIS_MODULE implicitly through a macro
>       usb: core: set mod_name in driver registration
>       usb: typec: set mod_name in driver registration
>       usb: ulpi: set mod_name in driver registration
> 
>  include/linux/ulpi/driver.h             |  4 ++--
>  include/linux/usb.h                     |  6 ++++--
>  include/linux/usb/typec_altmode.h       |  4 ++--
>  drivers/net/usb/r8152.c                 |  2 +-
>  drivers/usb/common/ulpi.c               |  4 +++-
>  drivers/usb/core/driver.c               | 10 ++++++----
>  drivers/usb/core/usb.c                  |  2 +-
>  drivers/usb/misc/apple-mfi-fastcharge.c |  2 +-
>  drivers/usb/misc/onboard_usb_dev.c      |  2 +-
>  drivers/usb/typec/bus.c                 |  4 +++-
>  drivers/usb/usbip/stub_main.c           |  2 +-
>  11 files changed, 25 insertions(+), 17 deletions(-)
> ---
> base-commit: 248951ddc14de84de3910f9b13f51491a8cd91df
> change-id: 20260722-mod_name_usb-e3baf58e1e1e

FWIW, I looked through these and they look OK to me.  I didn't see
any obvious errors (but I'm not a USB or driver or sysfs developer).
Given that, a "Reviewed-by" might be too strong, but you can add
an "Acked-by" for me if you'd like.

We should talk some time about my (half-baked) tool to find the
config options associated with files and source code line numbers.
It sounds like it has similar goals to what these patches are trying to
enable.
 -- Tim