Re: [PATCH v6 5/8] KVM: x86/pmu: Support PERF_METRICS MSR in mediated vPMU

[Chen, Zide]

On 7/23/2026 12:59 PM, Jim Mattson wrote:
> On Mon, Jun 29, 2026 at 4:28 PM Zide Chen <zide.chen@xxxxxxxxx> wrote:
>>
>> From: Dapeng Mi <dapeng1.mi@xxxxxxxxxxxxxxx>
>>
>> Bit 15 in IA32_PERF_CAPABILITIES indicates that the CPU provides
>> built-in support for Topdown Microarchitecture Analysis (TMA) L1
>> metrics via the IA32_PERF_METRICS MSR.
>>
>> Expose this capability only when mediated vPMU is enabled, as emulating
>> IA32_PERF_METRICS in the legacy vPMU model is impractical.
>>
>> Pass IA32_PERF_METRICS through to the guest only when mediated vPMU is
>> enabled and bit 15 is set in guest IA32_PERF_CAPABILITIES.  Allow
>> kvm_pmu_{get,set}_msr() to handle this MSR for host accesses.
>>
>> Save and restore this MSR on host/guest PMU context switches so that
>> host PMU activity does not clobber the guest value, and guest state
>> is not leaked into the host.
>>
>> Signed-off-by: Dapeng Mi <dapeng1.mi@xxxxxxxxxxxxxxx>
>> Signed-off-by: Zide Chen <zide.chen@xxxxxxxxx>
>> ---
>> v5:
>> - Remove host_initiated check in set/get MSR handlers.
>> v4:
>> - Remove WARN_ON_ONCE() and simply reject the guest accesses by checking
>>   host_initiated. (Sashiko)
>> - Passthru MSR_PERF_METRICS only if has_mediated_pmu is true. (Sashiko)
>> - Remove the redundant !! in vcpu_has_perf_metrics().
>> v3:
>> - Replace WARN_ON() with WARN_ON_ONCE(). (Dapeng)
>> - Add comments to explain why we don't validate writes on PERF_METRICS.
>> ---
>>  arch/x86/include/asm/kvm_host.h   |  1 +
>>  arch/x86/include/asm/msr-index.h  |  1 +
>>  arch/x86/include/asm/perf_event.h |  1 +
>>  arch/x86/kvm/msrs.c               |  6 +++++-
>>  arch/x86/kvm/pmu.h                |  5 +++++
>>  arch/x86/kvm/vmx/pmu_intel.c      | 31 +++++++++++++++++++++++++++++++
>>  arch/x86/kvm/vmx/vmx.c            |  7 +++++++
>>  7 files changed, 51 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
>> index 80f638588bf7..96376d8a5199 100644
>> --- a/arch/x86/include/asm/kvm_host.h
>> +++ b/arch/x86/include/asm/kvm_host.h
>> @@ -630,6 +630,7 @@ struct kvm_pmu {
>>         u64 global_status_rsvd;
>>         u64 reserved_bits;
>>         u64 raw_event_mask;
>> +       u64 perf_metrics;
>>         struct kvm_pmc gp_counters[KVM_MAX_NR_GP_COUNTERS];
>>         struct kvm_pmc fixed_counters[KVM_MAX_NR_FIXED_COUNTERS];
>>
>> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
>> index 18c4be75e927..fdcaeb6c8352 100644
>> --- a/arch/x86/include/asm/msr-index.h
>> +++ b/arch/x86/include/asm/msr-index.h
>> @@ -331,6 +331,7 @@
>>  #define PERF_CAP_PEBS_FORMAT           0xf00
>>  #define PERF_CAP_FW_WRITES             BIT_ULL(13)
>>  #define PERF_CAP_PEBS_BASELINE         BIT_ULL(14)
>> +#define PERF_CAP_PERF_METRICS          BIT_ULL(15)
>>  #define PERF_CAP_PEBS_TIMING_INFO      BIT_ULL(17)
>>  #define PERF_CAP_PEBS_MASK             (PERF_CAP_PEBS_TRAP | PERF_CAP_ARCH_REG | \
>>                                          PERF_CAP_PEBS_FORMAT | PERF_CAP_PEBS_BASELINE | \
>> diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
>> index 1eb13673e889..bc2e1cbcd9b9 100644
>> --- a/arch/x86/include/asm/perf_event.h
>> +++ b/arch/x86/include/asm/perf_event.h
>> @@ -447,6 +447,7 @@ static inline bool is_topdown_idx(int idx)
>>  #define GLOBAL_STATUS_ARCH_PEBS_THRESHOLD_BIT  54
>>  #define GLOBAL_STATUS_ARCH_PEBS_THRESHOLD      BIT_ULL(GLOBAL_STATUS_ARCH_PEBS_THRESHOLD_BIT)
>>  #define GLOBAL_STATUS_PERF_METRICS_OVF_BIT     48
>> +#define GLOBAL_STATUS_PERF_METRICS_OVF         BIT_ULL(GLOBAL_STATUS_PERF_METRICS_OVF_BIT)
>>
>>  #define GLOBAL_CTRL_EN_PERF_METRICS            BIT_ULL(48)
>>  /*
>> diff --git a/arch/x86/kvm/msrs.c b/arch/x86/kvm/msrs.c
>> index 3bf42d90ad14..c751a8dbd45d 100644
>> --- a/arch/x86/kvm/msrs.c
>> +++ b/arch/x86/kvm/msrs.c
>> @@ -230,7 +230,7 @@ static const u32 msrs_to_save_pmu[] = {
>>         MSR_ARCH_PERFMON_FIXED_CTR0, MSR_ARCH_PERFMON_FIXED_CTR1,
>>         MSR_ARCH_PERFMON_FIXED_CTR2, MSR_ARCH_PERFMON_FIXED_CTR3,
>>         MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_CORE_PERF_GLOBAL_STATUS,
>> -       MSR_CORE_PERF_GLOBAL_CTRL,
>> +       MSR_CORE_PERF_GLOBAL_CTRL, MSR_PERF_METRICS,
>>         MSR_IA32_PEBS_ENABLE, MSR_IA32_DS_AREA, MSR_PEBS_DATA_CFG,
>>
>>         /* This part of MSRs should match KVM_MAX_NR_INTEL_GP_COUNTERS. */
>> @@ -2625,6 +2625,10 @@ static void kvm_probe_msr_to_save(u32 msr_index)
>>                      intel_pt_validate_hw_cap(PT_CAP_num_address_ranges) * 2))
>>                         return;
>>                 break;
>> +       case MSR_PERF_METRICS:
>> +               if (!(kvm_caps.supported_perf_cap & PERF_CAP_PERF_METRICS))
>> +                       return;
>> +               break;
>>         case MSR_ARCH_PERFMON_PERFCTR0 ...
>>              MSR_ARCH_PERFMON_PERFCTR0 + KVM_MAX_NR_GP_COUNTERS - 1:
>>                 if (msr_index - MSR_ARCH_PERFMON_PERFCTR0 >=
>> diff --git a/arch/x86/kvm/pmu.h b/arch/x86/kvm/pmu.h
>> index 1b2f66a2e915..3066cade5790 100644
>> --- a/arch/x86/kvm/pmu.h
>> +++ b/arch/x86/kvm/pmu.h
>> @@ -279,6 +279,11 @@ static inline u64 kvm_vcpu_get_perf_caps(struct kvm_vcpu *vcpu)
>>         return vcpu->arch.perf_capabilities;
>>  }
>>
>> +static inline bool kvm_vcpu_has_perf_metrics(struct kvm_vcpu *vcpu)
>> +{
>> +       return kvm_vcpu_get_perf_caps(vcpu) & PERF_CAP_PERF_METRICS;
>> +}
>> +
>>  void kvm_pmu_deliver_pmi(struct kvm_vcpu *vcpu);
>>  int kvm_pmu_rdpmc(struct kvm_vcpu *vcpu, unsigned pmc, u64 *data);
>>  int kvm_pmu_check_rdpmc_early(struct kvm_vcpu *vcpu, unsigned int idx);
>> diff --git a/arch/x86/kvm/vmx/pmu_intel.c b/arch/x86/kvm/vmx/pmu_intel.c
>> index e426ddc8add4..225afd3937c3 100644
>> --- a/arch/x86/kvm/vmx/pmu_intel.c
>> +++ b/arch/x86/kvm/vmx/pmu_intel.c
>> @@ -188,6 +188,8 @@ static bool intel_is_valid_msr(struct kvm_vcpu *vcpu, u32 msr)
>>         switch (msr) {
>>         case MSR_CORE_PERF_FIXED_CTR_CTRL:
>>                 return kvm_pmu_has_perf_global_ctrl(pmu);
>> +       case MSR_PERF_METRICS:
>> +               return kvm_vcpu_has_perf_metrics(vcpu);
>>         case MSR_IA32_PEBS_ENABLE:
>>                 ret = kvm_vcpu_get_perf_caps(vcpu) & PERF_CAP_PEBS_FORMAT;
>>                 break;
>> @@ -345,6 +347,9 @@ static int intel_pmu_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>>         case MSR_CORE_PERF_FIXED_CTR_CTRL:
>>                 msr_info->data = pmu->fixed_ctr_ctrl;
>>                 break;
>> +       case MSR_PERF_METRICS:
>> +               msr_info->data = pmu->perf_metrics;
>> +               break;
>>         case MSR_IA32_PEBS_ENABLE:
>>                 msr_info->data = pmu->pebs_enable;
>>                 break;
>> @@ -394,6 +399,15 @@ static int intel_pmu_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>>                 if (pmu->fixed_ctr_ctrl != data)
>>                         reprogram_fixed_counters(pmu, data);
>>                 break;
>> +       case MSR_PERF_METRICS:
>> +               /*
>> +                * On platforms that support only hardware level-1, bits [63:32]
>> +                * are reserved and ignored by hardware. If hardware level-2 is also
>> +                * supported, they may contain valid metric data.
>> +                * Either way, guest writes are passed through verbatim.
>> +                */
>> +               pmu->perf_metrics = data;
>> +               break;
>>         case MSR_IA32_PEBS_ENABLE:
>>                 if (data & pmu->pebs_enable_rsvd)
>>                         return 1;
>> @@ -589,6 +603,11 @@ static void intel_pmu_refresh(struct kvm_vcpu *vcpu)
>>                 pmu->global_status_rsvd &=
>>                                 ~MSR_CORE_PERF_GLOBAL_OVF_CTRL_TRACE_TOPA_PMI;
>>
>> +       if (perf_capabilities & PERF_CAP_PERF_METRICS) {
>> +               pmu->global_ctrl_rsvd &= ~GLOBAL_CTRL_EN_PERF_METRICS;
>> +               pmu->global_status_rsvd &= ~GLOBAL_STATUS_PERF_METRICS_OVF;
>> +       }
>> +
>>         if (perf_capabilities & PERF_CAP_PEBS_FORMAT) {
>>                 if (perf_capabilities & PERF_CAP_PEBS_BASELINE) {
>>                         pmu->pebs_enable_rsvd = counter_rsvd;
>> @@ -632,6 +651,9 @@ static void intel_pmu_init(struct kvm_vcpu *vcpu)
>>
>>  static void intel_pmu_reset(struct kvm_vcpu *vcpu)
>>  {
>> +       struct kvm_pmu *pmu = vcpu_to_pmu(vcpu);
>> +
>> +       pmu->perf_metrics = 0;
>>         intel_pmu_release_guest_lbr_event(vcpu);
>>  }
>>
>> @@ -803,6 +825,9 @@ static void intel_mediated_pmu_load(struct kvm_vcpu *vcpu)
>>         struct kvm_pmu *pmu = vcpu_to_pmu(vcpu);
>>         u64 global_status, toggle;
>>
>> +       if (kvm_vcpu_has_perf_metrics(vcpu))
>> +               wrmsrq(MSR_PERF_METRICS, pmu->perf_metrics);
>> +
> 
> Our internal Sashiko asks:
> 
> Does this write to MSR_PERF_METRICS violate the architectural requirement to
> write IA32_FIXED_CTR3 first?
> According to the Intel SDM, software must write to IA32_FIXED_CTR3 before
> writing to IA32_PERF_METRICS to properly clear the TMA internal state machine.
> During VM-entry, kvm_pmu_load_guest_pmcs() is called before
> intel_mediated_pmu_load() to load the fixed counters. However, it
> conditionally skips the write if the guest's counter value matches the host
> hardware's current value:
> kvm_pmu_load_guest_pmcs() {
>     ...
>     if (pmc->counter != rdpmc(INTEL_PMC_FIXED_RDPMC_BASE | i))
>         wrmsrq(fixed_counter_msr(i), pmc->counter);
>     ...
> }
> If skipped, KVM will unconditionally write to MSR_PERF_METRICS here in
> intel_mediated_pmu_load() without a preceding write to IA32_FIXED_CTR3. Could
> this omission fail to reset the TMA state machine and potentially break
> TMA metrics?

IA32_PERF_GLOBAL_CTRL is already cleared before either fixed counter 3
or MSR_PERF_METRICS is restored.

The SDM does not appear to require an explicit WRMSR to fixed counter 3.
If the write is skipped, the hardware already contains the guest's fixed
counter 3 value.


>>         rdmsrq(MSR_CORE_PERF_GLOBAL_STATUS, global_status);
>>         toggle = pmu->global_status ^ global_status;
>>         if (global_status & toggle)
>> @@ -831,6 +856,12 @@ static void intel_mediated_pmu_put(struct kvm_vcpu *vcpu)
>>          */
>>         if (pmu->fixed_ctr_ctrl_hw)
>>                 wrmsrq(MSR_CORE_PERF_FIXED_CTR_CTRL, 0);
>> +
>> +       if (kvm_vcpu_has_perf_metrics(vcpu)) {
>> +               pmu->perf_metrics = rdpmc(INTEL_PMC_FIXED_RDPMC_METRICS);
>> +               if (pmu->perf_metrics)
>> +                       wrmsrq(MSR_PERF_METRICS, 0);
> 
> And here:
> 
> Will clearing MSR_PERF_METRICS here occur before clearing
> MSR_CORE_PERF_FIXED_CTR3, reversing the architecturally mandated write order?
> In KVM's mediated PMU context switch out (VM-exit), kvm_mediated_pmu_put()
> calls the mediated_put callback before clearing the guest PMCs:
> kvm_mediated_pmu_put() {
>     ...
>     kvm_pmu_call(mediated_put)(vcpu);
>     kvm_pmu_put_guest_pmcs(vcpu);
>     ...
> }
> This means intel_mediated_pmu_put() writes 0 to MSR_PERF_METRICS here, and
> then kvm_pmu_put_guest_pmcs() conditionally writes 0 to
> MSR_CORE_PERF_FIXED_CTR3 later. Additionally, if the fixed counter is already
> 0, the write to FIXED_CTR3 is skipped entirely.
> Could this write to MSR_PERF_METRICS without a preceding initialization of
> FIXED_CTR3 corrupt the hardware state machine or cause undefined behavior?

Similarly, IA32_PERF_GLOBAL_CTRL is already cleared at this point, so
both EN_FIXED_CTR3 and EN_PERF_METRICS have already been disabled.

The SDM guidance that "fixed counter 3 must be restored before
PERF_METRICS" appears to apply only to a running PMU, which is not the
case here.