Re: [PATCH v2 2/2] xfs: restore nofs context unconditionally in xfs_trans_roll

[Christoph Hellwig]

On Fri, Jul 24, 2026 at 12:08:33PM +0800, Zhou, Yun wrote:
>> Having a maze of single or two caller magic macros that modify global
>> (or rather global-ish as it's per thread) state makes hairy bits like
>> this really error prone as seen by the bugs now found.
>
> It's been a few days since the last discussion. I'm planning to
> respin as v3 following Christoph's suggestion (drop the helper,
> re-save directly in xfs_trans_roll). Any other suggestions?

Sounds good to me.