Re: [PATCH v3 01/17] media: i2c: os05b10: Use pm_runtime_get_if_active() when applying controls

[Tarang Raval]

Hi Jai,                                                                        
                                                                               
> Quoting Tarang Raval (2026-07-19 01:38:52)                                   
> > os05b10_set_ctrl() currently uses pm_runtime_get_if_in_use() to decide     
> > whether controls should be applied to hardware.                            
> >                                                                            
> > Use pm_runtime_get_if_active() instead so controls are applied whenever    
> > the device is runtime-active, regardless of the current usage count.       
>                                                                              
> What was your motivation behind this change?                                 
>                                                                              
> This is a bit wasteful, because this driver unconditionally calls            
> __v4l2_ctrl_handler_setup() in enable_streams(), along with writing the      
> whole register table again, without checking if the device was active or     
> sleeping. So updating some control registers in set_ctrl() seems like doing  
> double work IMHO.                                                            
                                                                               
I will drop this patch in v4.                                                  
                                                                               
Based on our previous discussion on this topic during the IMX678 driver 
series, I agree that this change is unnecessary.                                                      
                                                                               
Best Regards,                                                                  
Tarang